Impl ZeroizeOnDrop for RsaPrivateKey+newtypes
#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RsaPrivateKey` self-zeroizes on drop, so add the `ZeroizeOnDrop` marker trait to `RsaPrivateKey` and all newtypes thereof, i.e. `DecryptingKey` and `SigningKey` for the various padding modes. This also removes the `Zeroize` impl on `RsaPrivateKey`, since it self-zeroizes on `Drop`, and allowing `Zeroize` might accidentally permit use-after-zeroize vulnerabilities.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RsaPrivateKeyself-zeroizes on drop, so add theZeroizeOnDropmarker trait toRsaPrivateKeyand all newtypes thereof, i.e.DecryptingKeyandSigningKeyfor the various padding modes.This also removes the
Zeroizeimpl onRsaPrivateKey, since it self-zeroizes onDrop, and allowingZeroizemight accidentally permit use-after-zeroize vulnerabilities.Closes #285.