Skip to content

Improved public key checks #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tarcieri merged 1 commit into from
Apr 25, 2023
Merged

Improved public key checks #307

tarcieri merged 1 commit into from
Apr 25, 2023

Conversation

@tarcieri
Copy link
Member

@tarcieri tarcieri commented Apr 25, 2023

Adds the following checks:

  • n is odd
  • e is odd
  • e < n

Closes #99

@tarcieri
Improved public key checks
dace218 
Adds the following checks:

- `n` is odd
- `e` is odd
- `e` < `n`

Closes #99
@tarcieri tarcieri merged commit faabaa7 into master Apr 25, 2023
@tarcieri tarcieri deleted the expand-public-key-checks branch April 25, 2023 14:36
dignifiedquire
dignifiedquire reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@tarcieri tarcieri mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dignifiedquire dignifiedquire dignifiedquire left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Checks performed in check_public seem insufficient

3 participants

@tarcieri @dignifiedquire