Skip to content

Impl Signer for pss::SigningKey #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tarcieri merged 1 commit into from
Apr 18, 2023
Merged

Impl Signer for pss::SigningKey #297

tarcieri merged 1 commit into from
Apr 18, 2023

Conversation

@tarcieri
Copy link
Member

@tarcieri tarcieri commented Apr 17, 2023

Gated under the getrandom feature.

Calls RandomizedSigner with OsRng.

cc @lumag

@tarcieri
Impl Signer for pss::SigningKey
0ae6d98 
Gated under the `getrandom` feature.

Calls `RandomizedSigner` with `OsRng`.
@tarcieri tarcieri requested a review from dignifiedquire April 17, 2023 21:05
@tarcieri tarcieri mentioned this pull request Apr 18, 2023
Merged
@lumag
Copy link
Contributor

lumag commented Apr 18, 2023

Don't we need to have getrandom declared as a feature in Cargo.toml?

@tarcieri
Copy link
Member Author

tarcieri commented Apr 18, 2023

@lumag it already is

@lumag
Copy link
Contributor

lumag commented Apr 18, 2023

I see :-)

@tarcieri tarcieri merged commit 1eb59f4 into master Apr 18, 2023
@tarcieri tarcieri deleted the pss-signer branch April 18, 2023 01:00
@tarcieri tarcieri mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarcieri @lumag