feat: implement associated AlgorithmIdentifier traits for PKCS1v15 an… #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Apr 2, 2023
tarcieri
reviewed
Apr 2, 2023
Contributor
Author
|
@tarcieri |
Member
Member
|
I'm pretty happy with the API. |
tarcieri
reviewed
Apr 3, 2023
…d PSS keys Allow getting the algorithm identifiers for signing keys Signed-off-by: Dmitry Baryshkov <[email protected]>
tarcieri
reviewed
Apr 3, 2023
Comment on lines
+710
to
+713
| /* | ||
| * We do not expect that any of this functions fails, unless the library is broken, so it | ||
| * is safe to use unwrap() | ||
| */ |
Member
There was a problem hiding this comment.
Perhaps it's better to use expect here?
Contributor
Author
There was a problem hiding this comment.
ack, I'll switch to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d PSS keys
Allow getting the algorithm identifiers for signing keys