Skip to content

Conversation

@baloo
Copy link
Member

@baloo baloo commented Mar 14, 2025

@baloo baloo marked this pull request as draft March 14, 2025 21:54
@newpavlov
Copy link
Member

I would wait with this migration a bit. I plan to open several PRs to change aead APIs further and we probably will need to discuss them a fair amount.

@baloo
Copy link
Member Author

baloo commented Mar 14, 2025

I don't mind waiting to merge but I'll get this branch to a point where it can be used in a [patch.crates-io] by a consumer which is not currently the case with master.

@tarcieri
Copy link
Member

tarcieri commented Mar 14, 2025

It would definitely be nice to get things in sync with master if we can. There are people who are trying to track these repos as git dependencies and that becomes difficult when they go out-of-sync. Ideally we'd have a PR to update the downstream repos ready to go before we merge changes in traits, which is my bad

@baloo baloo force-pushed the baloo/inout-v2 branch 2 times, most recently from b37f66c to 96a264b Compare March 17, 2025 05:54
@baloo baloo force-pushed the baloo/inout-v2 branch 11 times, most recently from 34abf4d to c333a41 Compare March 17, 2025 20:49
@baloo baloo force-pushed the baloo/inout-v2 branch 2 times, most recently from fdc90c2 to 1bd4230 Compare March 18, 2025 03:08
@baloo
Copy link
Member Author

baloo commented Mar 21, 2025

I'll need to sort out the lack of MockBuffer for ascon and deoxys: RustCrypto/traits#1802 (comment)

@baloo baloo force-pushed the baloo/inout-v2 branch 4 times, most recently from 40846f9 to 90ddf77 Compare March 24, 2025 21:55
@baloo baloo force-pushed the baloo/inout-v2 branch 2 times, most recently from 2aa4af8 to 5aff1e3 Compare March 31, 2025 16:37
@baloo baloo force-pushed the baloo/inout-v2 branch 4 times, most recently from f6eb096 to d009899 Compare April 17, 2025 19:24
@baloo baloo marked this pull request as ready for review April 17, 2025 19:25
@baloo
Copy link
Member Author

baloo commented Apr 17, 2025

last bit is ascon-aead and are located in #673 but that got closed.

@tarcieri
Copy link
Member

@baloo can you update/recreate #673 so we can get this merged?

@baloo
Copy link
Member Author

baloo commented Apr 19, 2025

@baloo can you update/recreate #673 so we can get this merged?

#687

This gets included here.

@baloo
Copy link
Member Author

baloo commented Apr 19, 2025

I think this is the last PR needed to reunite the workspace in formats.

@tarcieri tarcieri merged commit 976052d into RustCrypto:master Apr 19, 2025
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants