Several improvements in the “Test-Network” and “Write-ToLog” functions. #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed $LogMsg to a mandatory parameter. - Optimized ACL settings for the log file. - Added try/catch block for error handling. - Modified the "Echo log" behavior to improve clarity. - Added UTF-8 encoding for better character support.
- Added robust error handling for registry key access and web requests. - Introduced configurable parameters for timeout and retry intervals. - Improved logging with detailed error messages for troubleshooting. - Restored notification logic: - Warning notification after 5 minutes of no connection. - Timeout notification after 30 minutes of no connection. - Refactored metered connection check for better readability and maintainability. - Ensured default fallback values for NCSI parameters when registry keys are unavailable.
Romanitho
reviewed
Jan 20, 2025
| Write-ToLog "WAU is configured to force update checking on metered connection" | ||
| return $true | ||
|
|
||
| } |
Owner
There was a problem hiding this comment.
We're missing this part of the logs. If you think it's not important, that's fine with me.
Contributor
Author
There was a problem hiding this comment.
Yes exactly, I forgot this part, you can put it back.
Contributor
|
Hi, why the Devskim error suppression was removed? |
Owner
|
Closing this PR as isn’t planned for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Improved Logging function :
Enhanced Test-Network function:
Related Issues