added parts for app meta and the default slot #937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
I've added new parts to aux-global-status-bar to open up more styling options for developers.
JIRA Link
ASTRO-4884
Related Issue
Discussion #993
General Notes
Motivation and Context
The GSB's default slot is difficult to center on the page. Since the GSB uses a flex-box model, if the right-slot is less wide than the left-slot + App container (as it most often is) then the content in the default slot will center on its surrounding container but NOT on the page. See Example
Issues and Limitations
Without adding a bunch of markup, this is a difficult thing to fix within the component itself. Every section of the GSB is slottable and we have no way to really know what developers will choose to put in each slot.
To that end, I added two parts: one on the container that wraps the app-data section and another on the container that wraps the default slot.
With these two extra style-able section, it should be significantly less challenging to place the default slot content where one would want it.
I don't LOVE the name I've given to the default slot wrapper part and would be very open to suggestion.
There is a centering proof-of-concept on center.html in the GSB test folder. This should be removed before we merge.
Types of changes
Checklist