Skip to content

Conversation

@tassoevan
Copy link
Collaborator

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2025

⚠️ No Changeset found

Latest commit: 1996070

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan force-pushed the feat/es2024 branch 4 times, most recently from 1d838bc to 6d1a462 Compare July 16, 2025 04:22
@tassoevan tassoevan changed the title feat: ES2024 and hybrid packages feat: ES2024 Jul 17, 2025
@tassoevan tassoevan marked this pull request as ready for review July 17, 2025 18:08
@tassoevan tassoevan requested review from a team and Copilot July 17, 2025 18:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to ES2024, centralizes TypeScript configurations via a new base tsconfig.base.json, and updates per-package tsconfig and build scripts to extend the base config. It also adds Turbo outputs and tweaks the memoize utility signature.

  • Update global compiler target to es2024 and module system to es2022, plus esModuleInterop
  • Consolidate per-package tsconfig.json files to extend the base config and remove redundant settings
  • Update package build scripts and add Turbo caching outputs
  • Refactor memoize to rename _options to options in its signature

Reviewed Changes

Copilot reviewed 54 out of 60 changed files in this pull request and generated 2 comments.

File Description
turbo.json Add outputs to build task
tsconfig.base.json Change target/module; add esModuleInterop
packages/memo/src/memoize.ts Rename _options to options; adjust WeakMap generic
packages/memo/src/memoize.spec.ts Add import from Jest; adjust spec file imports
Comments suppressed due to low confidence (1)

packages/memo/src/memoize.spec.ts:1

  • Tests for the new maxAge expiration logic are missing. Consider adding a test that uses an options.maxAge value and verifies that cached entries are cleared after the timeout.
import { it, jest, expect, describe } from '@jest/globals';

@tassoevan tassoevan marked this pull request as draft October 6, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants