-
Notifications
You must be signed in to change notification settings - Fork 194
feat: ES2024 #1717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: ES2024 #1717
Conversation
|
1d838bc to
6d1a462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the project to ES2024, centralizes TypeScript configurations via a new base tsconfig.base.json, and updates per-package tsconfig and build scripts to extend the base config. It also adds Turbo outputs and tweaks the memoize utility signature.
- Update global compiler target to
es2024and module system toes2022, plusesModuleInterop - Consolidate per-package
tsconfig.jsonfiles to extend the base config and remove redundant settings - Update package build scripts and add Turbo caching outputs
- Refactor
memoizeto rename_optionstooptionsin its signature
Reviewed Changes
Copilot reviewed 54 out of 60 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| turbo.json | Add outputs to build task |
| tsconfig.base.json | Change target/module; add esModuleInterop |
| packages/memo/src/memoize.ts | Rename _options to options; adjust WeakMap generic |
| packages/memo/src/memoize.spec.ts | Add import from Jest; adjust spec file imports |
Comments suppressed due to low confidence (1)
packages/memo/src/memoize.spec.ts:1
- Tests for the new
maxAgeexpiration logic are missing. Consider adding a test that uses anoptions.maxAgevalue and verifies that cached entries are cleared after the timeout.
import { it, jest, expect, describe } from '@jest/globals';
Proposed changes (including videos or screenshots)
Issue(s)
Further comments