-
Notifications
You must be signed in to change notification settings - Fork 13.7k
fix: Missing "Open in room" button on widget's shared screen #40331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fd53844
Add missing button to widget
gabriellsh a92d75a
Add changeset
gabriellsh 2cc3288
Merge branch 'develop' into fix/voiceOpenInRoom
gabriellsh 5dcd0fe
Merge branch 'develop' into fix/voiceOpenInRoom
gabriellsh 580dd7c
Merge branch 'develop' into fix/voiceOpenInRoom
gabriellsh 23ddc7b
Merge branch 'develop' into fix/voiceOpenInRoom
gabriellsh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@rocket.chat/i18n": minor | ||
| "@rocket.chat/ui-voip": minor | ||
| --- | ||
|
|
||
| Adds "Open in room" button to shared screen card on voice call widget |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
packages/ui-voip/src/components/Cards/StreamCard/StreamCardOpenInRoom.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { Button } from '@rocket.chat/fuselage'; | ||
| import { useTranslation } from 'react-i18next'; | ||
|
|
||
| import CardSlotContainer from '../CardSlot'; | ||
|
|
||
| type StreamCardOpenInRoomButtonProps = { | ||
| onClick: () => void; | ||
| showOnHover?: boolean; | ||
| }; | ||
|
|
||
| const StreamCardOpenInRoomButton = ({ onClick, showOnHover = false }: StreamCardOpenInRoomButtonProps) => { | ||
| const { t } = useTranslation(); | ||
| return ( | ||
| <CardSlotContainer position='middle' variant='transparent' showOnHover={showOnHover} margin={0}> | ||
| <Button primary small icon='arrow-expand' onClick={onClick}> | ||
| {t('Open_in_room')} | ||
| </Button> | ||
| </CardSlotContainer> | ||
| ); | ||
| }; | ||
|
|
||
| export default StreamCardOpenInRoomButton; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.