Fix action cancellation by passing status from JSON #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
force-pushed
the
fix-action-status
branch
from
98730e2 to
6d738f8
Compare
This was referenced Sep 29, 2024
Contributor
Author
|
Meh, I guess CI doesn't set the Since Iron is EOL in like 2 months, I'm kind of okay working around this problem by removing the Iron CI job or continuing to have this test skipped for a bit longer. As people prefer. |
EzraBrooks
reviewed
Oct 1, 2024
Contributor
EzraBrooks
left a comment
EzraBrooks
left a comment
There was a problem hiding this comment.
Do we squash in this repo? if so, we probably should separate the pre-commit changes from the functional changes for commit traceability
Contributor
Author
Yeah, good idea. Will do! |
sea-bass
force-pushed
the
fix-action-status
branch
from
d76782c to
5ed480a
Compare
Contributor
Author
|
Offloaded pre-commit stuff to #954 -- that should be merged before this one to keep history clean. |
sea-bass
force-pushed
the
fix-action-status
branch
from
0d9209a to
fea1eaa
Compare
9 tasks
sea-bass
added a commit
that referenced
this pull request
Oct 3, 2024
sea-bass
added a commit
that referenced
this pull request
Oct 3, 2024
sea-bass
added a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
This slightly changes the protocol, specifically that the
action_resultmessage now contains an additionalstatusfield which contains an integer corresponding to the enum in https://docs.ros2.org/latest/api/action_msgs/msg/GoalStatus.html.This does mean that the client libraries (namely,
roslibjswhich has the only working implementation) need to be updated as well.Description
As described above, this PR adds a new
statusfield to theaction_resultmessage to handle action cancellation properly.Closes #920 ... maybe?