refactored ctf test-subscription-content-filter to improve reliability #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggangw
approved these changes
Apr 17, 2023
Member
minggangw
left a comment
minggangw
left a comment
There was a problem hiding this comment.
Thanks for adding these well-designed cases, it ensures the quality! gltm
minggangw
pushed a commit
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test-subscription-content-filter.js test-suite has proven to be unstable when running in CI, e.g., frequent timeout waiting for msgs published by external publisher processes. My initial response (hack) was to increase wait times. This improved reliability some but still there are frequent failures due to timeout. To improve the reliability of this test-suite I've rewritten it to run test msg publishers in a single process along with the CTF subscriptions. Publishers and subscriptions run on different nodes. This seems to be much better reliability in my CI test environment.