Adds msg generation support for workspace overlays #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revises the message_generation process as follows: 1. recursively delete the generated/ folder before generating new message files 2. process the AMENT_PREFIX_PATH in reverse order such that interfaces defined earlier on the AMENT_PREFIX_PATH will overwrite older versions of the interface. Thus interfaces defined in a ROS overlay workspace take precedent over a version of the interface defined in an underlay. Additional mods were made to help address a stability issue involving content-filters. - updated mocha to version 10.2 - added native clearContentFilter() to rcl_bindings.cpp - reimplemented subscription#clearContentFilter() to use new native implementation - edited test-subscription-content-filter.js
minggangw
approved these changes
Mar 16, 2023
Member
minggangw
left a comment
minggangw
left a comment
There was a problem hiding this comment.
Thanks for the patch, LGTM!
Collaborator
Author
|
@minggangw Thx for the review. |
Member
|
Thanks @wayneparrott , I'm going to merge this PR! |
minggangw
pushed a commit
that referenced
this pull request
Apr 3, 2023
* Adds msg generation support for workspace overlays Revises the message_generation process as follows: 1. recursively delete the generated/ folder before generating new message files 2. process the AMENT_PREFIX_PATH in reverse order such that interfaces defined earlier on the AMENT_PREFIX_PATH will overwrite older versions of the interface. Thus interfaces defined in a ROS overlay workspace take precedent over a version of the interface defined in an underlay. Additional mods were made to help address a stability issue involving content-filters. - updated mocha to version 10.2 - added native clearContentFilter() to rcl_bindings.cpp - reimplemented subscription#clearContentFilter() to use new native implementation - edited test-subscription-content-filter.js * Removed unused commented code per PR reviewer feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revises the message_generation process as follows:
generated/folder before generating new message filesAdditional mods were made to help address a stability issue involving content-filters in CI:
Fix #902