Skip to content

Conversation

@wayneparrott
Copy link
Collaborator

Adds overloaded declarations that omit the options parameter for methods:

Node.createSubscription()
Node.createService()

Fix #873

Added:
```
createSubscription()
createService()
```
Copy link
Member

@minggangw minggangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@minggangw minggangw merged commit 4ebb442 into RobotWebTools:develop Aug 10, 2022
minggangw pushed a commit that referenced this pull request Nov 18, 2022
Added:
```
createSubscription()
createService()
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Types should support overloaded Node methods

2 participants