Enable ActionUuid for TypeScript #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
If this PR is out of scope for this project I have an alt location with additional convenience support for rclnodejs actions here. I can host it there for a while and see how generally useful it is to others. So no pressure to accept! |
minggangw
approved these changes
Jul 27, 2022
Member
minggangw
left a comment
minggangw
left a comment
There was a problem hiding this comment.
make sense to wrap these functions into a module, thanks for improving this and LGTM!
minggangw
pushed a commit
that referenced
this pull request
Jul 29, 2022
* Fix ActionServer cancelCallback declaration, doc & test * impls ActionUuid w/ tests #870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with rclnodejs actions I found myself copy-paste code for working with UUIDs in client-side goals. Rather than repeat this pattern multiple times I decided to update and externalize the ActionUuid found in lib/action/uuid.js for general use.
Changes:
Fix #870