humble port #853
Merged
humble port #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored distro info as 1st class concept -- Added distro.js, distro.d.ts, test-distro.js -- Updated index.js with DistroUtils property -- Update dts main.ts with DistroUtils test - Updated bindings.gyp to setup include_dirs to support nested <ros>/include/<prj>/<prj>/*.h structure of Humble (goofy) - Refactored scripts/ros_distro.js to use distro.js - Updated linux workflow with separate build actions for each ros distro [galactic, humble, rolling] - Removed CircleCI config as OSX builds are not well supported beyond Galactic Update dated docs for Humble/Node17 support
minggangw
approved these changes
May 27, 2022
Member
minggangw
left a comment
minggangw
left a comment
There was a problem hiding this comment.
lgtm, thanks for covering the ci on different distros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored distro info as 1st class concept
-- Added distro.js, distro.d.ts, test-distro.js
-- Updated index.js with DistroUtils property
-- Update dts main.ts with DistroUtils test
Updated bindings.gyp to setup include_dirs to support nested
/include///*.h structure of Humble (goofy)
Refactored scripts/ros_distro.js to use distro.js
Updated linux workflow with separate build actions for each ros distro
[galactic, humble, rolling]
Removed CircleCI config as OSX builds are not well supported beyond
Galactic
Update dated docs for Humble/Node17 support
Fix #852