Skip to content

Conversation

@wayneparrott
Copy link
Collaborator

Presently when a developer pulls code on windows his editor may show a zillion prettier errors due to the Windows default EOL does not match the default prettier EOL of LF. By adding a .gitattributes we can enforce the EOL to be LF (compatible with prettier) on all platforms by default.

This .gitattributes file is based on this example. I added some additional EOL config for *.[json|yaml|cpp|hpp] and a few others. Please review and propose any changes you feel better suit the project and developer experience.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 91.015% when pulling 6b6170d on wayneparrott:gitattributes into 24d86f5 on RobotWebTools:develop.

Copy link
Member

@minggangw minggangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@minggangw minggangw merged commit 8ebe705 into RobotWebTools:develop Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants