Use std::shared_ptr to manage the memory #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use new operator to allocate variable of type rmw_qos_profile_t and return raw pointer later, which may lead to memory leak in some case. In this patch, we will leverage std::unique_ptr to take the ownership of the allocated memory to avoid not deallocating the memory later. Fix RobotWebTools#380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use new operator to allocate variable of type
rmw_qos_profile_t, which may lead to memory leak in some case.
In this patch, we will leverage std::shared_ptr to manage the allocated
memory to avoid not deallocating the memory later.
Fix #380