Skip to content

[workspace] Upgrade crate_universe to latest#22255

Merged
jwnimmer-tri merged 4 commits intoRobotLocomotion:masterfrom
nicolecheetham:upgrade-crate_universe
Dec 5, 2024
Merged

[workspace] Upgrade crate_universe to latest#22255
jwnimmer-tri merged 4 commits intoRobotLocomotion:masterfrom
nicolecheetham:upgrade-crate_universe

Conversation

@nicolecheetham
Copy link
Copy Markdown
Contributor

@nicolecheetham nicolecheetham commented Dec 3, 2024

Towards #22240


This change is Reviewable

@jwnimmer-tri jwnimmer-tri self-assigned this Dec 4, 2024
@jwnimmer-tri
Copy link
Copy Markdown
Collaborator

Well, the proximate cause seems to be dtolnay/unicode-ident#28 which changed the license text. Now I need to figure out why crate_universe is failing to parse the new text.

@jwnimmer-tri jwnimmer-tri removed their assignment Dec 4, 2024
@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Dec 4, 2024
@jwnimmer-tri
Copy link
Copy Markdown
Collaborator

+@rpoyner-tri for both reviews, please.

Copy link
Copy Markdown
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 22 of 25 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @nicolecheetham)

@jwnimmer-tri jwnimmer-tri merged commit d8d6c9c into RobotLocomotion:master Dec 5, 2024
@jwnimmer-tri jwnimmer-tri added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Dec 5, 2024
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Co-authored-by: Jeremy Nimmer <jeremy.nimmer@tri.global>
@nicolecheetham nicolecheetham deleted the upgrade-crate_universe branch January 2, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html status: squashing now https://drake.mit.edu/reviewable.html#curated-commits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants