Enable running pyright with older versions

[ItsDrike]

When there's a new version of pyright available, running pyright checker will produce a warning and end with non-zero exit code:

While this warning is helpful in letting users know that there's a newer version and they should update, this makes it very hard to use pyright-python in an automated way, since it'd require explicitly setting PYRIGHT_PYTHON_FORCE_VERSION environment variable to the version of pyright we want to use (i.e. the version of the pyright-python package we have installed) which we'd need to be obtaining manually.

I think that while this warning is helpful and it should stay there, it really shouldn't block pyrighr completely and cause non-zero exit code. This is simply necessary because even though repositories should be updating their dependencies, not all repos can be expected to simply update the minute a new version comes out, realistically it will take a while for the repo to update, and during that time, all CI tests would be failing everywhere, since pyright-python doesn't even allow running old pyright versions, unless specified explicitly, even though it is versioned to represent which pyright version should it install and run.

[RobertCraigie]

I think that while this warning is helpful and it should stay there, it really shouldn't block pyrighr completely and cause non-zero exit code.

@ItsDrike the warning should not affect the exit code, something else is going wrong if you're getting non-zero exit codes.

since pyright-python doesn't even allow running old pyright versions, unless specified explicitly

Could you expand more on what you mean with this please? You should be able to use old pyright versions either by installing the equivalent pyright-python package or by setting PYRIGHT_PYTHON_FORCE_VERSION to the desired version.

The only caveat with using older versions is the warning message but that shouldn't stop you from being able to use it.

[ItsDrike]

Could you expand more on what you mean with this please? You should be able to use old pyright versions either by installing the equivalent pyright-python package or by setting PYRIGHT_PYTHON_FORCE_VERSION to the desired version.

Well, I thought that there was no way (other than setting the variable), to run older (not up to date) versions, even when the pyright-python's version is set to the older one. From your response, it would appear that this is not the implemented behavior and that the warning shouldn't stop pyright completely.

However if that's so, there's something else that does cause the non-zero return code and pyright doesn't even run. The attached picture has the whole output captured, there's nothing else to be seen, the program simply exists after the warning, with 217 exit code, no other indication on what's wrong, so I figured it must've been the warning. Or this behavior is implemented incorrectly and it is in fact the warning which is causing this exit code.

I should probably point out that I do have a higher version of pyright installed globally on my machine and only the project's dependencies specify a not yet updated version, perhaps that's an issue?
(Notice that even here, I tried to run pyright --version using the pyright-python pip dependency within poetry environment, and it failed with the same return code, only printing out the warning, so I used pip show to get the installed version)

My global pyright is installed via my distribution's package manager (I'm on arch, so via pyright package in pacman)
Perhaps that's something that may be causing this? But if it is, that really shouldn't be the case, the package should only install pyright into the virtual environment, regardless of any global configuration.

[ItsDrike]

Minimal reproducable example (at least with my config on arch):

[RobertCraigie]

That is strange, could you run it with the environment variable PYRIGHT_PYTHON_DEBUG set to 1 and see what that outputs.

[RobertCraigie]

@ItsDrike Either this is an issue with your local setup or a linux / arch issue as running the exact same steps on darwin works as expected.

[ItsDrike]

[RobertCraigie]

What happens if you run /usr/bin/npx --silent --yes -- pyright@1.1.226 --version?

[ItsDrike]

It simply fails, but without silent, there are some error messages:

Here's the generated log file:
2022-03-09T14_20_31_355Z-debug-0.log

[RobertCraigie]

What does /home/itsdrike/.local/share/npm/_npx/939808f5c7d70bfb/node_modules/.bin/pyright --version output?

[ItsDrike]

What does /home/itsdrike/.local/share/npm/_npx/939808f5c7d70bfb/node_modules/.bin/pyright --version output?

pyright 1.1.226

[RobertCraigie]

It does sound like this issue could be because of the global pyright you've installed, could you try uninstalling that and see if that fixes the error?

[ItsDrike]

The error is still there:

Though it is likely that simply removing pyright doesn't remove some things that were done by the package manager and it leaves them behind. Once again, I'm attaching the generated log file:
2022-03-09T14_52_16_072Z-debug-0.log

[RobertCraigie]

You could try deleting /home/itsdrike/.local/share/npm/_npx/939808f5c7d70bfb. This is a bizarre issue, might be worth reporting to npm.

[ItsDrike]

You could try deleting /home/itsdrike/.local/share/npm/_npx/939808f5c7d70bfb.

That did the trick:

This is a bizarre issue, might be worth reporting to npm.

So, what exactly even went wrong here?