Add ability to overwrite templates multiple times using templateFolder - #1835
Merged
lahma merged 1 commit intoJul 11, 2025
Merged
Conversation
lahma
approved these changes
Jul 11, 2025
lahma
left a comment
Collaborator
There was a problem hiding this comment.
Seems reasonable and non-breaking. thanks for the PR!
This was referenced Jul 30, 2025
Merged
This was referenced Sep 15, 2025
This was referenced Sep 28, 2025
This was referenced Oct 6, 2025
This was referenced Oct 17, 2025
This was referenced Oct 24, 2025
This was referenced Nov 3, 2025
This was referenced Jul 17, 2026
This was referenced Jul 27, 2026
This was referenced Aug 3, 2026
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most of imports I am using one set of templates. But for some services I need to change templates slightly.
In order to avoid keeping full copy of templates, I proppose to use multiple template directories. So template factory will try to find template in the first directory, than in the second directory and so on until it comes to the default templates.
To fulfil this without changing settings I propose to split templateDirectory by semicolon (
;) and to use nonempty parts as pathes to template directories.Existing settings will be affected if template directory path contains semicolon. That seems to be very rare case, that can be easily fixed.