C# generator: create anoymous types with camel casing (3rd attempt) #1828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
approved these changes
Jul 27, 2025
Collaborator
lahma
left a comment
lahma
left a comment
There was a problem hiding this comment.
This seems to be correct, we need to regenerate snapshots on NSwag side after referencing the new version.
|
I’m experiencing the same issue with the second class name being generated in lowercase. (NSwag.MSBuild, 14.4.0) Example:
I was wondering when the next release is planned? Also, is there any chance I could get access to the nightly builds NuGet package? Thanks |
Contributor
Author
|
@stevo-knievo The pull request to update NJsonSchema in NSwag is RicoSuter/NSwag#5177 |
This was referenced Sep 15, 2025
This was referenced Sep 28, 2025
This was referenced Oct 17, 2025
This was referenced Oct 24, 2025
This was referenced Nov 4, 2025
This was referenced Nov 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same code change as #1788. The previous pull request was reverted later due to a test failure in NSwag that is caused by this change (see screenshot in #1788 (comment)). After some struggle, I managed to run the NSwag testsuite and will send a pull request for it, too. The testsuite for the NSwag pull request will fail as long as the NJsonSchema version containing this change is not updated.
As it turned out, the NSwag testsuite already contains a test case for this change of mine :-)
=======================
This is the third attempt to fix RicoSuter/NSwag#4849 and RicoSuter/NSwag#4837 and a followup for #1716: since NSwag 14, the resulting C# file generated from a yaml file might contain lower case class names.
This seems to happen if an array item has as lower case type name hint (e.g. "data"), and a class "Data" was already generated.
In this situation,
DefaultTypeNameGenerator.GenerateAnonymousTypeNamedoes not callConversionUtilities.ConvertToUpperCamelCaseand thus picks the lower case class name "data" as "not used".With my fix, it would generate a class "Data2" again.
The first fix worked locally for me because I had one additional line that I forget to add to my pull request. This request adds this line and removes an unneccesary
ConvertToUpperCamelCasefrom the previous pull request (variabletypeNameHintis already camel cased now).By the way: it would be great to have a step by step guide how to build NJsonSchema and update it in NSwag ;-)
fixes RicoSuter/NSwag#4837