Fix variable access for joint limits in assembly #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… evaluation; updates to assembly to pass such data. Required for variable-defined joint limits
Contributor
|
Hello, Using variables for joint limits should actually work. I just fixed an issue about the way case was handled in variable names that could have causes such issue. Can you check on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Expression.py to call assembly-level variables for expression evaluation; updates to assembly to pass such data. Required for variable-defined joint limits.
The tool didn't invoke variable table calls in the expression parser, so if you had variable-driven joint limits it would evaluate it as the variable string name rather than parsing it through the variable table. Fixed.
(Mostly Cursor).