RESTCOMM-1785 : Add Extension point in SmppMessageHandler.redirectToHostedSmsApp #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulazizali77
changed the title
…icate notification() from SMSService.
gvagenas
force-pushed
the
RESTCOMM-1785
branch
from
da1ca52 to
7fc54bc
Compare
gvagenas
force-pushed
the
master
branch
2 times, most recently
from
9469191 to
c67f142
Compare
gvagenas
force-pushed
the
RESTCOMM-1785
branch
from
7fc54bc to
90545cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Block incoming SMS
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #RESTCOMM-1785
Special notes for your reviewer:
SmppMessageHandler.notification()is duplicated verbatim fromSmsService.notification(). Should be cleaned up later