Skip to content

Add inspector transpiler #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nytra wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Add inspector transpiler #122

Changes from 16 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
72cbffe
Add cursed inspector transpiler (not fully working)
Nytra Jun 20, 2025
af99c57
It works now
Nytra Jun 20, 2025
c0990c1
Remove old prefix
Nytra Jun 20, 2025
a265ab3
Improve it to not rely on counting number of branches
Nytra Jun 20, 2025
7070fed
More improvements
Nytra Jun 20, 2025
24449db
Add Enabled checks
Nytra Jun 20, 2025
f184653
Improve label names and simplify branching
Nytra Jun 20, 2025
4dc2bc3
Simplify more
Nytra Jun 20, 2025
6803dbe
Remove labels array and fixup custom inspectors
Nytra Jun 20, 2025
457e397
Simplify more again
Nytra Jun 20, 2025
7a0e7a3
More comments
Nytra Jun 20, 2025
43682b8
It now matches the old patch completely
Nytra Jun 20, 2025
f7a2351
Simplify more again again
Nytra Jun 20, 2025
651512b
Use a local to store the vertical layout
Nytra Jun 20, 2025
412e03c
Actually we don't need to store the vertical layout
Nytra Jun 20, 2025
f0985a5
Remove unnecessary method
Nytra Jun 20, 2025
64d49e6
Increment index inside indexer and remove braces on If
Nytra Jun 21, 2025
8f6f93e
Store the methods used in transpiler
Nytra Jun 21, 2025
23c203c
Make the patch more robust by not using hardcoded local indices
Nytra Jun 23, 2025
c0bec8c
Store UIBuilder constructor and add another check for if the local in…
Nytra Jun 23, 2025
4c75c4d
Some code style cleanup
Banane9 Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
158 changes: 120 additions & 38 deletions MonkeyLoader.Resonite.Integration/UI/Inspectors/CustomInspectorInjector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using System.Reflection.Emit;

namespace MonkeyLoader.Resonite.UI.Inspectors
{
Expand All @@ -17,61 +19,136 @@ internal sealed class CustomInspectorInjector
{
public override bool CanBeDisabled => true;

[HarmonyPrefix]
private static bool BuildUIForComponentPrefix(WorkerInspector __instance, Worker worker,
bool allowRemove, bool allowDuplicate, bool allowContainer, Predicate<ISyncMember> memberFilter)
{
if (!Enabled)
return true;
private static MethodInfo _buildHeaderMethod = AccessTools.Method(typeof(CustomInspectorInjector), nameof(OnBuildInspectorHeader));
private static MethodInfo _buildHeaderTextMethod = AccessTools.Method(typeof(CustomInspectorInjector), nameof(OnBuildInspectorHeaderText));
private static MethodInfo _buildBodyMethod = AccessTools.Method(typeof(CustomInspectorInjector), nameof(OnBuildInspectorBody));
private static MethodInfo _getEnabledMethod = AccessTools.Method(typeof(CustomInspectorInjector), nameof(GetEnabled));

var ui = new UIBuilder(__instance.Slot);
RadiantUI_Constants.SetupEditorStyle(ui);
ui.Style.RequireLockInToPress = true;
var vertical = ui.VerticalLayout(6f);
private static bool GetEnabled()
{
return Enabled;
}

if (worker is not Slot)
private static Label? GetNextBranchLabel(CodeInstruction[] codes, int startIndex)
{
int i = startIndex;
while (i < codes.Length)
{
ui.Style.MinHeight = 32f;
ui.HorizontalLayout(4f);
ui.Style.MinHeight = 24f;
ui.Style.FlexibleWidth = 1000f;
if (codes[i].Branches(out var label))
{
return label;
}
i++;
}
return null;
}

[HarmonyTranspiler]
static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstruction> instructions, ILGenerator generator)
{
Label? afterHeaderBranchLabel = null;
Label? afterHeaderTextBranchLabel = null;
bool headerDone = false;
bool headerTextDone = false;
bool bodyDone = false;

OnBuildInspectorHeader(ui, __instance, worker, allowContainer, allowDuplicate, allowRemove, memberFilter);
Label afterHeaderPatchLabel = generator.DefineLabel();

ui.NestInto(vertical.Slot);
}
Label afterHeaderTextPatchLabel = generator.DefineLabel();

OnBuildInspectorHeaderText(ui, worker);
Label beforeBodyPatchLabel = generator.DefineLabel();
Label afterBodyPatchLabel = generator.DefineLabel();

if (worker is ICustomInspector customInspector)
CodeInstruction[] instArr = instructions.ToArray();
for (int i = 0; i < instArr.Length; i++)
{
try
var instruction = instArr[i];
bool branchFound = false;
if (afterHeaderBranchLabel is null && instruction.opcode == OpCodes.Brtrue && instArr[i-1].opcode == OpCodes.Isinst && instArr[i - 1].operand == (object)typeof(Slot))
{
ui.Style.MinHeight = 24f;
customInspector.BuildInspectorUI(ui);
afterHeaderBranchLabel = (Label)instruction.operand;
branchFound = true;
}
catch (Exception ex)
if (!branchFound && afterHeaderBranchLabel != null && !headerDone)
{
ui.Text((LocaleString)"EXCEPTION BUILDING UI. See log");
UniLog.Error(ex.ToString(), stackTrace: false);
// check Enabled
yield return new CodeInstruction(OpCodes.Call, _getEnabledMethod);
yield return new CodeInstruction(OpCodes.Brfalse, afterHeaderPatchLabel);

// do header patch
yield return new CodeInstruction(OpCodes.Ldloc_0);
yield return new CodeInstruction(OpCodes.Ldarg, 0);
yield return new CodeInstruction(OpCodes.Ldarg, 1);
yield return new CodeInstruction(OpCodes.Ldarg, 2);
yield return new CodeInstruction(OpCodes.Ldarg, 3);
yield return new CodeInstruction(OpCodes.Ldarg, 4);
yield return new CodeInstruction(OpCodes.Ldarg, 5);
yield return new CodeInstruction(OpCodes.Call, _buildHeaderMethod);

// skip original if did patch
yield return new CodeInstruction(OpCodes.Br, afterHeaderBranchLabel);

// mark after patch (start of original)
yield return new CodeInstruction(OpCodes.Nop) { labels = [afterHeaderPatchLabel] };
headerDone = true;
}
}
else
{
WorkerInspector.BuildInspectorUI(worker, ui, memberFilter);
}
// this patch calls OnBuildInspectorHeaderText unconditionally (even if there is no InspectorHeaderAttribute)
if (afterHeaderTextBranchLabel is null && !headerTextDone &&
instruction.opcode == OpCodes.Ldloc_1 &&
instArr[i-1].opcode == OpCodes.Stloc_1 &&
instArr[i-2].Calls(AccessTools.Method(typeof(CustomAttributeExtensions), nameof(CustomAttributeExtensions.GetCustomAttribute), [typeof(MemberInfo)], [typeof(InspectorHeaderAttribute)])))
{
afterHeaderTextBranchLabel = GetNextBranchLabel(instArr, i+1);

OnBuildInspectorBody(ui, __instance, worker, allowContainer, allowDuplicate, allowRemove, memberFilter);
// check Enabled
yield return new CodeInstruction(OpCodes.Call, _getEnabledMethod);
yield return new CodeInstruction(OpCodes.Brfalse, afterHeaderTextPatchLabel);

ui.Style.MinHeight = 8f;
ui.Panel();
ui.NestOut();
// do header text patch
yield return new CodeInstruction(OpCodes.Ldloc_0);
yield return new CodeInstruction(OpCodes.Ldarg, 1);
yield return new CodeInstruction(OpCodes.Call, _buildHeaderTextMethod);

// skip original if did patch
yield return new CodeInstruction(OpCodes.Br, afterHeaderTextBranchLabel);

return false;
// mark after patch (start of original)
yield return new CodeInstruction(OpCodes.Nop) { labels = [afterHeaderTextPatchLabel] };
headerTextDone = true;
}
if (instruction.opcode == OpCodes.Leave_S &&
(instArr[i - 1].Calls(AccessTools.Method(typeof(UniLog), nameof(UniLog.Error))) || instArr[i - 1].Calls(AccessTools.Method(typeof(ICustomInspector), nameof(ICustomInspector.BuildInspectorUI)))))
{
instruction.operand = beforeBodyPatchLabel;
}
yield return instruction;
if (!bodyDone && instruction.Calls(AccessTools.Method(typeof(WorkerInspector), nameof(WorkerInspector.BuildInspectorUI))))
{
// check Enabled
yield return new CodeInstruction(OpCodes.Call, _getEnabledMethod) { labels = [beforeBodyPatchLabel] };
yield return new CodeInstruction(OpCodes.Brfalse, afterBodyPatchLabel);

// do body patch
yield return new CodeInstruction(OpCodes.Ldloc_0);
yield return new CodeInstruction(OpCodes.Ldarg, 0);
yield return new CodeInstruction(OpCodes.Ldarg, 1);
yield return new CodeInstruction(OpCodes.Ldarg, 2);
yield return new CodeInstruction(OpCodes.Ldarg, 3);
yield return new CodeInstruction(OpCodes.Ldarg, 4);
yield return new CodeInstruction(OpCodes.Ldarg, 5);
yield return new CodeInstruction(OpCodes.Call, _buildBodyMethod);

// there is no "original" in this case

// mark after patch (start of original)
yield return new CodeInstruction(OpCodes.Nop) { labels = [afterBodyPatchLabel] };
bodyDone = true;
}
}
}

private static void OnBuildInspectorBody(UIBuilder ui, WorkerInspector inspector, Worker worker,
bool allowContainer, bool allowDuplicate, bool allowDestroy, Predicate<ISyncMember> memberFilter)
bool allowDestroy, bool allowDuplicate, bool allowContainer, Predicate<ISyncMember> memberFilter)
{
var root = ui.Root;

Expand All @@ -83,10 +160,15 @@ private static void OnBuildInspectorBody(UIBuilder ui, WorkerInspector inspector
}

private static void OnBuildInspectorHeader(UIBuilder ui, WorkerInspector inspector, Worker worker,
bool allowContainer, bool allowDuplicate, bool allowDestroy, Predicate<ISyncMember> memberFilter)
bool allowDestroy, bool allowDuplicate, bool allowContainer, Predicate<ISyncMember> memberFilter)
{
var root = ui.Root;

ui.Style.MinHeight = 32f;
ui.HorizontalLayout(4f);
ui.Style.MinHeight = 24f;
ui.Style.FlexibleWidth = 1000f;

var eventData = new BuildInspectorHeaderEvent(ui, inspector, worker, allowContainer, allowDuplicate, allowDestroy, memberFilter);

Dispatch(eventData);
Expand Down
Loading