Skip to content

Add inspector transpiler #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nytra wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Add inspector transpiler #122

Changes from 3 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
72cbffe
Add cursed inspector transpiler (not fully working)
Nytra Jun 20, 2025
af99c57
It works now
Nytra Jun 20, 2025
c0990c1
Remove old prefix
Nytra Jun 20, 2025
a265ab3
Improve it to not rely on counting number of branches
Nytra Jun 20, 2025
7070fed
More improvements
Nytra Jun 20, 2025
24449db
Add Enabled checks
Nytra Jun 20, 2025
f184653
Improve label names and simplify branching
Nytra Jun 20, 2025
4dc2bc3
Simplify more
Nytra Jun 20, 2025
6803dbe
Remove labels array and fixup custom inspectors
Nytra Jun 20, 2025
457e397
Simplify more again
Nytra Jun 20, 2025
7a0e7a3
More comments
Nytra Jun 20, 2025
43682b8
It now matches the old patch completely
Nytra Jun 20, 2025
f7a2351
Simplify more again again
Nytra Jun 20, 2025
651512b
Use a local to store the vertical layout
Nytra Jun 20, 2025
412e03c
Actually we don't need to store the vertical layout
Nytra Jun 20, 2025
f0985a5
Remove unnecessary method
Nytra Jun 20, 2025
64d49e6
Increment index inside indexer and remove braces on If
Nytra Jun 21, 2025
8f6f93e
Store the methods used in transpiler
Nytra Jun 21, 2025
23c203c
Make the patch more robust by not using hardcoded local indices
Nytra Jun 23, 2025
c0bec8c
Store UIBuilder constructor and add another check for if the local in…
Nytra Jun 23, 2025
4c75c4d
Some code style cleanup
Banane9 Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 104 additions & 44 deletions MonkeyLoader.Resonite.Integration/UI/Inspectors/CustomInspectorInjector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using System.Reflection;
using System.Reflection.Emit;

namespace MonkeyLoader.Resonite.UI.Inspectors
{
Expand All @@ -17,61 +19,113 @@
{
public override bool CanBeDisabled => true;

[HarmonyPrefix]
private static bool BuildUIForComponentPrefix(WorkerInspector __instance, Worker worker,
bool allowRemove, bool allowDuplicate, bool allowContainer, Predicate<ISyncMember> memberFilter)
{
if (!Enabled)
return true;

var ui = new UIBuilder(__instance.Slot);
RadiantUI_Constants.SetupEditorStyle(ui);
ui.Style.RequireLockInToPress = true;
var vertical = ui.VerticalLayout(6f);

if (worker is not Slot)
{
ui.Style.MinHeight = 32f;
ui.HorizontalLayout(4f);
ui.Style.MinHeight = 24f;
ui.Style.FlexibleWidth = 1000f;

OnBuildInspectorHeader(ui, __instance, worker, allowContainer, allowDuplicate, allowRemove, memberFilter);
private static MethodInfo _buildHeaderMethod = AccessTools.Method(typeof(CustomInspectorInjector), nameof(OnBuildInspectorHeader));
private static MethodInfo _buildHeaderTextMethod = AccessTools.Method(typeof(CustomInspectorInjector), nameof(OnBuildInspectorHeaderText));
private static MethodInfo _buildBodyMethod = AccessTools.Method(typeof(CustomInspectorInjector), nameof(OnBuildInspectorBody));
private static MethodInfo _storeVerticalLayoutMethod = AccessTools.Method(typeof(CustomInspectorInjector), nameof(StoreVerticalLayout));

ui.NestInto(vertical.Slot);
}
private static VerticalLayout _verticalLayout;

Check warning on line 27 in MonkeyLoader.Resonite.Integration/UI/Inspectors/CustomInspectorInjector.cs

View workflow job for this annotation

GitHub Actions / Build 

Non-nullable field '_verticalLayout' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

OnBuildInspectorHeaderText(ui, worker);
private static void StoreVerticalLayout(VerticalLayout layout)
{
_verticalLayout = layout;
}

if (worker is ICustomInspector customInspector)
[HarmonyTranspiler]
static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstruction> instructions)
{
bool storedVerticalLayout = false;
Label? headerLabel = null;
Label? headerTextLabel = null;
bool headerDone = false;
bool headerTextDone = false;
bool bodyDone = false;
bool afterHeaderBranch = false;
bool afterHeaderTextBranch = false;
int numBranches = 0;
int branchDepth = 0;
List<Label?> labels = new();
foreach (var instruction in instructions)
{
try
bool didBranch = false;
if (instruction.Branches(out var label))
{
ui.Style.MinHeight = 24f;
customInspector.BuildInspectorUI(ui);
if (numBranches == 0)
headerLabel = label;
else if (numBranches == 6)
headerTextLabel = label;
numBranches++;
branchDepth++;
didBranch = true;
labels.Add(label);
}
catch (Exception ex)
if (!didBranch)
{
ui.Text((LocaleString)"EXCEPTION BUILDING UI. See log");
UniLog.Error(ex.ToString(), stackTrace: false);
if (branchDepth > 0)
{
foreach (var storedLabel in labels.ToArray())
{
if (instruction.labels.Contains(storedLabel!.Value) && instruction.operand != (object)storedLabel!.Value)
{
if (storedLabel == headerLabel)
afterHeaderBranch = true;
else if (storedLabel == headerTextLabel)
afterHeaderTextBranch = true;
labels.Remove(storedLabel);
branchDepth--;
break;
}
}
}
if (numBranches == 1 && !headerDone)
{
// do header
yield return new CodeInstruction(OpCodes.Ldloc_0);
yield return new CodeInstruction(OpCodes.Ldarg, 0);
yield return new CodeInstruction(OpCodes.Ldarg, 1);
yield return new CodeInstruction(OpCodes.Ldarg, 2);
yield return new CodeInstruction(OpCodes.Ldarg, 3);
yield return new CodeInstruction(OpCodes.Ldarg, 4);
yield return new CodeInstruction(OpCodes.Ldarg, 5);
yield return new CodeInstruction(OpCodes.Call, _buildHeaderMethod);
headerDone = true;
}
if (numBranches == 7 && !headerTextDone)
{
// do header text
yield return new CodeInstruction(OpCodes.Ldloc_0);
yield return new CodeInstruction(OpCodes.Ldarg, 1);
yield return new CodeInstruction(OpCodes.Call, _buildHeaderTextMethod);
headerTextDone = true;
}
}
if (headerDone && !afterHeaderBranch) continue;
if (headerTextDone && !afterHeaderTextBranch) continue;
yield return instruction;
if (!storedVerticalLayout && instruction.Calls(AccessTools.Method(typeof(UIBuilder), nameof(UIBuilder.VerticalLayout), [typeof(float), typeof(float), typeof(Alignment?), typeof(bool?), typeof(bool?)])))
{
yield return new CodeInstruction(OpCodes.Dup);
yield return new CodeInstruction(OpCodes.Call, _storeVerticalLayoutMethod);
storedVerticalLayout = true;
}
if (!bodyDone && instruction.Calls(AccessTools.Method(typeof(WorkerInspector), nameof(WorkerInspector.BuildInspectorUI))))
{
// do body
yield return new CodeInstruction(OpCodes.Ldloc_0);
yield return new CodeInstruction(OpCodes.Ldarg, 0);
yield return new CodeInstruction(OpCodes.Ldarg, 1);
yield return new CodeInstruction(OpCodes.Ldarg, 2);
yield return new CodeInstruction(OpCodes.Ldarg, 3);
yield return new CodeInstruction(OpCodes.Ldarg, 4);
yield return new CodeInstruction(OpCodes.Ldarg, 5);
yield return new CodeInstruction(OpCodes.Call, _buildBodyMethod);
bodyDone = true;
}
}
else
{
WorkerInspector.BuildInspectorUI(worker, ui, memberFilter);
}

OnBuildInspectorBody(ui, __instance, worker, allowContainer, allowDuplicate, allowRemove, memberFilter);

ui.Style.MinHeight = 8f;
ui.Panel();
ui.NestOut();

return false;
}

private static void OnBuildInspectorBody(UIBuilder ui, WorkerInspector inspector, Worker worker,
bool allowContainer, bool allowDuplicate, bool allowDestroy, Predicate<ISyncMember> memberFilter)
bool allowDestroy, bool allowDuplicate, bool allowContainer, Predicate<ISyncMember> memberFilter)
{
var root = ui.Root;

Expand All @@ -83,15 +137,21 @@
}

private static void OnBuildInspectorHeader(UIBuilder ui, WorkerInspector inspector, Worker worker,
bool allowContainer, bool allowDuplicate, bool allowDestroy, Predicate<ISyncMember> memberFilter)
bool allowDestroy, bool allowDuplicate, bool allowContainer, Predicate<ISyncMember> memberFilter)
{
ui.Style.MinHeight = 32f;
ui.HorizontalLayout(4f);
ui.Style.MinHeight = 24f;
ui.Style.FlexibleWidth = 1000f;

var root = ui.Root;

var eventData = new BuildInspectorHeaderEvent(ui, inspector, worker, allowContainer, allowDuplicate, allowDestroy, memberFilter);

Dispatch(eventData);

ui.NestInto(root);
ui.NestInto(_verticalLayout.Slot);
}

private static void OnBuildInspectorHeaderText(UIBuilder ui, Worker worker)
Expand Down
Loading