Conversation
[IQE-3627] Playwright migration basics with smart-locator
IQE-3628: Browser, base, utils, exceptions playwright migration
IQE-3630: Widget Migration
IQE-3631: Iframe handling
IQE-3629: Windows handling
IQE-3605: Unit test page improvement
Coverage improvement and fixes
Improve github action test pipeline
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 86.54% 93.52% +6.97%
==========================================
Files 18 19 +1
Lines 2572 2610 +38
==========================================
+ Hits 2226 2441 +215
+ Misses 346 169 -177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Migrate existing docs to playwright.
updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.7 → v0.12.9](astral-sh/ruff-pre-commit@v0.12.7...v0.12.9) - [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0)
updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.9 → v0.12.12](astral-sh/ruff-pre-commit@v0.12.9...v0.12.12)
Browser cache
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
this overall looks like a nice simplification
some additional research in making use of the playwright based robustness should be done as we may be able to drop a lot more of the selenium-fragility-handling code
| @property | ||
| def selected(self): | ||
| return self.browser.is_selected(self) | ||
| def selected(self) -> bool: |
There was a problem hiding this comment.
we share a huge portion of the impl with the normal checkbox it seems
| return None | ||
|
|
||
|
|
||
| class SmartLocator(namedtuple("SmartLocator", ["by", "locator"])): |
There was a problem hiding this comment.
if we dont actually use themas tuples, a frozen dataclass may be better
mshriver
changed the title
|
@RonnyPfannschmidt completely agree with your assessments, and there will be continued updates to the documentation as well before we release as 2.0. That being said, I'm going to proceed with this into |
|
Is there maintenance branch already prepared? |
|
@mshriver @RonnyPfannschmidt I will raise one small MR with dataclass |
3 participants
No description provided.