Remove Unused Dependency: typing_extensions#245
Remove Unused Dependency: typing_extensions#245LightOfHeaven1994 merged 1 commit intoRedHatQE:masterfrom
Conversation
|
Hello @digitronik, @mshriver, @LightOfHeaven1994 I hope this message finds you all well. We are currently engaged in a research project focused on optimizing projects by identifying and eliminating unnecessary dependencies. Your insights and expertise as maintainers would greatly contribute to our research efforts. Could you please take a moment to review the changes proposed on this PR? Your input would be highly valuable to us. Thank you for your consideration! |
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 86.45% 86.45%
=======================================
Files 18 18
Lines 2570 2570
=======================================
Hits 2222 2222
Misses 348 348
Flags with carried forward coverage won't be shown. Click here to find out more. |
LightOfHeaven1994
left a comment
There was a problem hiding this comment.
Great catch, thank you!
Summary
This pull request removes the unused dependency
typing_extensionsfrom thesetup.cfgconfiguration file. The removal of this dependency is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.Rationale
The
typing_extensionslibrary was originally introduced to the project in #192 for its use in thesrc/widgetastic/types.pyfile. However, as of now, the said file (src/widgetastic/types.py) has been deleted, and the dependency appears to be unused within the source code, while it continues to be listed in the project's dependency files.Removing this unused dependency reduces the overall footprint of the application, mitigating potential security risks, and simplifying the dependency management process.
Changes
setup.cfg.Impact