fix: restore dynamic imports removed by ruff modernization#188
Merged
Conversation
The ArrayOfEnumOptionId import was accidentally removed in commit 992340c when ruff consolidated imports. The original # NOQA comment was not recognized by ruff, causing the "unused" import to be removed. This import is required for dynamic custom field type resolution in get_custom_fields() which uses globals()[type_name] to look up classes. Also adds Properties import which may be needed for other custom field types. Signed-off-by: Wayne Sun <gsun@redhat.com>
Collaborator
Author
|
Verified by user and unit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayOfEnumOptionIdimport that was accidentally removed in commit 992340c when ruff consolidated importsPropertiesimport which may be needed for other custom field types# noqa: F401comments to prevent future removal by ruffRoot Cause
The modernization commit 992340c ("chore: modernize tooling and drop legacy Python versions") accidentally removed the
ArrayOfEnumOptionIdimport. The original# NOQAcomment was not recognized by ruff when it consolidated imports from separate lines into one line.This import is required for dynamic custom field type resolution in
get_custom_fields()which usesglobals()[type_name]to look up classes at runtime.Test plan
ArrayOfEnumOptionIdtype work correctly