Fix/add test record by object#177
Merged
waynesun09 merged 6 commits intoApr 16, 2024
Merged
Conversation
- run pre-commit checks
leelavg
approved these changes
Apr 12, 2024
Collaborator
There was a problem hiding this comment.
if possible could you pls make this diff reviewable? In this commit c78247e (4th feat: make test_run agnostic of test_work_item_type) the current diff is entire file newly edited which is confusing.
Collaborator
|
Collaborator
|
/hold merge for rework on reviewable diff |
13b653c to
fea942f
Compare
- create_incident_report and generate_description are now methods of TestRun class
fea942f to
c597fb1
Compare
Contributor
Author
|
I cleaned up my history :) |
Collaborator
|
Great work, I've tested it and it pass my local test without regression. For test local, after create a dummy project and prepared a Thanks for working on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR is addresses #175.
I refactored the functions
create_incident_reportandgenerate_descriptionto methods of the classTestRun.In those two methods, I circumnavigate the usage of
TestCaseby using the project's predefined test case work item (member ofproject.get_tests_configuration()).Should also this work item type not exist, I use the base class
_WorkItem.I have tested this exploratively on my side, but I could not figure out how to run the unit tests. Can I do that at all?