Osidb-4661: Set new PURL parser library #1148
Conversation
roduran-dev
force-pushed
the
OSIDB-4661_purl_library
branch
4 times, most recently
from
2056571 to
7d9ff98
Compare
roduran-dev
force-pushed
the
OSIDB-4661_purl_library
branch
from
7d9ff98 to
c013082
Compare
| import re | ||
| import uuid | ||
|
|
||
| import particular_purl_parse as purl_parser |
There was a problem hiding this comment.
The method and the new library's function had the same name ps_component_from_purl.
having ps_component_from_purl inside ps_component_from_purl seemed like it would cause confusion and renaming ps_component_from_purl seemed also wrong and particular_purl_parse.ps_component_from_purl seems too long so I rename the library to just do purl_parser.ps_component_from_purl
| "markdown>=3.3.6", | ||
| "nvdlib>=0.7.6", | ||
| "packageurl-python>=0.16.0", | ||
| "particular-purl-parse @ git+https://github.com/RedHatProductSecurity/particular-purl-parse.git#subdirectory=py", |
There was a problem hiding this comment.
This library is not publish on Pypi so I use the library.
Elkasitu
left a comment
Elkasitu
left a comment
There was a problem hiding this comment.
Nothing wrong with the code per se, but I think we should get the library in proper shape before using it in downstream projects:
- set up tests in the library, should be a txt/json file of inputs/outputs that should be ran by the TS and PY libraries
- document if needed
- deploy to at least PyPI, optionally NPM
I saw some tests in the library but I think what you're asking is a bit different. @MrMarble and @superbuggy do you think you could add this to the project? (If not maybe at just publish in Pypi) |
The library is not publish en pypi yet.
Closes Osidb-4661