Add underscores for Windows tile config#26
Merged
phbernard merged 4 commits intoRealFaviconGenerator:masterfrom Mar 31, 2021
craighutch:patch-2
Merged
Add underscores for Windows tile config#26phbernard merged 4 commits intoRealFaviconGenerator:masterfrom craighutch:patch-2
phbernard merged 4 commits intoRealFaviconGenerator:masterfrom
craighutch:patch-2
Conversation
added 4 commits
February 6, 2021 21:28
"windows80Ie10Tile" and "windows10Ie11EdgeTiles" config options need to have underscores before both sets of numbers. Converting from camelCase to underscore previously yielded "windows80_ie10_tile" and "windows10_ie11_edge_tiles", which was incorrect. After the change the conversion now yields the correct values of "windows_80_ie_10_tile" and "windows_10_ie_11_edge_tiles".
color "#134f97" was getting converted to "#134f_97", so adding additional requirement that number must be followed by an uppercase letter
exclude "background_color" and "theme_color" from camelCase to underscore conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"windows80Ie10Tile" and "windows10Ie11EdgeTiles" config options need to have underscores before both sets of numbers.
Converting from camelCase to underscore previously yielded "windows80_ie10_tile" and "windows10_ie11_edge_tiles", which was incorrect.
After the change the conversion now yields the correct values of "windows_80_ie_10_tile" and "windows_10_ie_11_edge_tiles".
Fixes RealFaviconGenerator/realfavicongenerator#267
Coincidentally Fixes RealFaviconGenerator/gulp-real-favicon#21
Coincidentally Fixes RealFaviconGenerator/grunt-real-favicon#43