Web app manifest relative URL logic

[kevinkelleher12]

First of all, thank you for creating RealFaviconGenerator!

I was trying to debug why npx realfavicon check is failing for me which led me here:

  } else {
    // Otherwise, append the path to the existing pathname
    return `${url.href}${url.href.endsWith('/') ? '' : '/'}${absoluteOrRelativePath}`;
  }

Is this correct? From the MDN docs:

If src is relative, the path is resolved relative to the manifest file's URL. For example, the relative URL images/icon-192x192.png for the manifest file located at https://example.com/manifest.json will be resolved as https://example.com/images/icon-192x192.png.

[phbernard]

In core/packages/check-favicon/src/helper.test.ts, I see:

expect(mergeUrlAndPath('https://example.com/sub-page', 'some/path')).toBe('https://example.com/sub-page/some/path');

Which seems to match the behavior you mention from MDN, doesn't it?