fix(expand): terminate recursive call when destination completes#793
fix(expand): terminate recursive call when destination completes#793kwonoj merged 1 commit intoReactiveX:masterfrom
Conversation
|
@kwonoj this PR might make sense to merge together with #788. With both PRs, the infinite expand of ScalarObservables causes stack overflow eventually, but at a very large number, If I add a small delay (hence converting the synchronous ScalarObservable to a normal async Observable), like So, I don't think very long living synchronous expands is something we need to support. This PR and PR #788 should be enough. |
|
I agree this PR need to be merged with #788 to correct its behaviors. Supporting infinite |
|
Mmm, yes, agreed. |
|
Merged with 3b8cf94. |
relates to #766
Partially resolves expand operator behavior by adding recursive call terminating condition. Still inifnite expand causes stack overflow though.
Feeling this might not be best way to solve issue, any suggestions would be gladly welcome.