fix(test): make explicit unsubscription for observable#754
Merged
kwonoj merged 1 commit intoReactiveX:masterfrom Nov 19, 2015
Merged
fix(test): make explicit unsubscription for observable#754kwonoj merged 1 commit intoReactiveX:masterfrom
kwonoj merged 1 commit intoReactiveX:masterfrom
Conversation
Member
|
Yes this PR makes perfect sense. Good discovery. |
Member
Author
|
Merged with 505f5b7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originated from #729 (comment) , with some of async test observables are not unsubscribed after test case is completed.
In most cases it'll be harmless but would be better to unsubscribe it explicitly.
@staltz , would like to ask opinions tests for
bufferWhen, if this revise would be legit or there should be better way to handle it.