fix(config): make sure that Promise config is undefined initially#3440
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Mar 16, 2018
Merged
fix(config): make sure that Promise config is undefined initially#3440benlesh merged 1 commit intoReactiveX:masterfrom
benlesh merged 1 commit intoReactiveX:masterfrom
Conversation
kwonoj
reviewed
Mar 16, 2018
spec/config-spec.ts
Outdated
| describe('config', () => { | ||
| it('should have a Promise property that defaults to nothing', () => { | ||
| expect('Promise' in config).to.be.true; | ||
| expect(config.Promise).to.equal(undefined); |
Member
There was a problem hiding this comment.
expect(config).to.have.property('Promise');
expect(config.Promise).to.be.undefined;
kwonoj
approved these changes
Mar 16, 2018
We need to make sure promise is undefined initially because systems like Zones need to have a chance to pick up Promise and patch it, and we're doing a runtime check for configuration anyhow. This makes the runtime check worthwhile and solves the problem with Zones (without needing to reference Zones in anyway)
benlesh
force-pushed
the
fix-promise-config
branch
from
2213c12 to
2818b45
Compare
IgorMinar
approved these changes
Mar 16, 2018
This was referenced Mar 19, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to make sure promise is undefined initially because systems like Zones need to have a chance to pick up Promise and patch it, and we're doing a runtime check for configuration anyhow. This makes the runtime check worthwhile and solves the problem with Zones (without needing to reference Zones in anyway)