chore(package): update package-lock

[kwonoj]

Description:
This PR pins all of our dependncies, also check in package-lock.json. Now package lock support becomes quite stable, it works on cross-platform without modifying dependency when just try to install dependencies. We may need bump up huge number of dependencies in here, but that's different story.

Related issue (if exists):

• closes Update dependency-cruiser #3284

[rxjs-bot]

	Warnings
⚠️	❗ Big PR (1)

	Messages
📖

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

CJS: 1358.3KB, global: 726.5KB (gzipped: 117.3KB), min: 140.3KB (gzipped: 30.6KB)

Generated by 🚫 dangerJS

[kwonoj]

🤔 just pinning dependency makes test fails?

[cartant]

Were they pinned to the most-recent, compatible versions? Or to potentially old versions?

[kwonoj]

pin just removed caret from version range. There should be some semver minor bumps with carets, but still making test fails seems bit odd.

[cartant]

How did that test ever pass? The implementation seems to explicitly not use the scheduler if there is only one observable?

if (observables.length === 1 || (observables.length === 2 && isScheduler(observables[1]))) {
  return from(<any>observables[0]);
}

---

This is the logged output:

  2517 passing (4s)
  4 pending
  1 failing
  1) Observable.concat should use the scheduler even when one Observable is concat'd:
     AssertionError: expected true to be false
      at Context.<anonymous> (spec/observables/concat-spec.ts:369:31)

And this is the failing test.

[kwonoj]

/cc @benlesh , I recall this test added recently.

[kwonoj]

The implementation seems to explicitly not use the scheduler if there is only one observable?

that's true, test case description is reading bit confusing. It concat's one observable + scheduler as param, which takes execution path for arguments length as > 1 .

[coveralls]

Coverage remained the same at 97.502% when pulling 35058a3 on kwonoj:chore-pkg-lock into 94156a2 on ReactiveX:master.

[kwonoj]

phew, bit larger work than I thought.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.