chore(typings): improve zip typings#2860
Closed
cartant wants to merge 1 commit intoReactiveX:masterfrom
Closed
Conversation
Add signature to the lettable zipProto so it's consistent with the non-lettable zipProto.
Collaborator
Author
|
Unfortunately, this PR falls victim to TypeScript matching arbitrary functions with export function zip<T>(...observables: Array<ObservableInput<T>>): OperatorFunction<T, T[]>;and: export function zip<T, R>(...observables: Array<ObservableInput<T> | ((...values: Array<T>) => R)>): OperatorFunction<T, R>;When This is a pity, as when This also means that the signature added in PR #2787 is also unsafe when |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add signature to the lettable zipProto so it's consistent with the
non-lettable zipProto.
Description:
This PR is closely related to #2787. In between that PR being submitted and its being merged there were WIP commits made re: lettable operators. Consequently, the overload signature that the PR added to the non-lettable
zipProtowas not included in the lettablezipProto.This PR adds the relevant overload to the lettable
zipProto.Related issue (if exists): #2784