Skip to content

Test PR to trigger danger : DONOTMERGE#2327

Closed
kwonoj wants to merge 3 commits intoReactiveX:masterfrom
kwonoj:test-danger-dummy
Closed

Test PR to trigger danger : DONOTMERGE#2327
kwonoj wants to merge 3 commits intoReactiveX:masterfrom
kwonoj:test-danger-dummy

Conversation

@kwonoj
Copy link
Member

@kwonoj kwonoj commented Feb 4, 2017

Description:

Related issue (if exists):

@rxjs-bot
Copy link

rxjs-bot commented Feb 4, 2017

Fails
🚫 an `only` was left in tests (sample-spec.ts,scan-spec.ts)
🚫 missing type definition import in tests (sample-spec.ts,scan-spec.ts) (1)

(1) : It seems updated test cases uses test scheduler interface hot, cold but miss to import type signature for those.

Generated by 🚫 dangerJS

@kwonoj kwonoj force-pushed the test-danger-dummy branch from 74c5434 to 4e3514e Compare February 4, 2017 23:01
@kwonoj kwonoj closed this Feb 4, 2017
@kwonoj kwonoj deleted the test-danger-dummy branch February 4, 2017 23:07
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants