fix(bindNodeCallback): properly set context of input function#2320
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Feb 2, 2017
mpodlasin:bind-node-callback-this
Merged
fix(bindNodeCallback): properly set context of input function#2320benlesh merged 1 commit intoReactiveX:masterfrom mpodlasin:bind-node-callback-this
benlesh merged 1 commit intoReactiveX:masterfrom
mpodlasin:bind-node-callback-this
Conversation
Set context of input function to context of output function, so that context can be controlled at call time and underlying observable is not available in input function
benlesh
approved these changes
Feb 2, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Set context of input function to context of output function, so that
context can be controlled at call time and underlying observable is
not available in input function
Related issue (if exists):
Detailed description in another pr, where situation is basically identical:
#2319