Skip to content

feat(ES2015): stop publishing rxjs-es#2019

Merged
jayphelps merged 1 commit intoReactiveX:masterfrom
benlesh:stop-the-rxjs-es
Oct 11, 2016
Merged

feat(ES2015): stop publishing rxjs-es#2019
jayphelps merged 1 commit intoReactiveX:masterfrom
benlesh:stop-the-rxjs-es

Conversation

@benlesh
Copy link
Member

@benlesh benlesh commented Oct 11, 2016

BREAKING CHANGE: rxjs-es is no longer being published
BREAKING CHANGE: @reactivex/rxjs no longer has /dist/es6 output

related #2016
related #1992
closes #1671
related #1954

BREAKING CHANGE: `rxjs-es` is no longer being published
BREAKING CHANGE: `@reactivex/rxjs` no longer has `/dist/es6` output

related #2016
related #1992
closes #1671
related #1954
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.039% when pulling 6be9968 on blesh:stop-the-rxjs-es into 418d597 on ReactiveX:master.

@jayphelps
Copy link
Member

LGTM

@jayphelps jayphelps merged commit dc915c4 into ReactiveX:master Oct 11, 2016
@kwonoj
Copy link
Member

kwonoj commented Oct 11, 2016

Manual compilation via npm script will still be supported? (*_es6 scripts other than compile for docs)

@jayphelps
Copy link
Member

jayphelps commented Oct 11, 2016

@kwonoj the plumbing around building the ES6 builds is still there, right now just used for docs. The es6 builds will no longer be included in @reactivex/rxjs and rxjs-es will no longer get new publishes and we'll mark it as deprecated.

@jayphelps
Copy link
Member

@kwonoj I may be misunderstanding your question tho. lmk.

@kwonoj
Copy link
Member

kwonoj commented Oct 11, 2016

@jayphelps yes, I'm aware of doc-related scripts and question is es6 build scripts are not being used for those. It's not a huge issue since it can be updated anytime.

@jayphelps
Copy link
Member

@kwonoj ahhh got it now. It has a minorly different npm script.

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop publishing rxjs-es. Move ES6 build to output .mjs files alongside the CJS .js files.

4 participants