Skip to content

style(docs): improve readability of publish_docs#2015

Merged
jayphelps merged 3 commits intoReactiveX:masterfrom
igncp:master
Oct 24, 2016
Merged

style(docs): improve readability of publish_docs#2015
jayphelps merged 3 commits intoReactiveX:masterfrom
igncp:master

Conversation

@igncp
Copy link
Contributor

@igncp igncp commented Oct 9, 2016

Hi,

Just saw this bash script (the only one in the repo) and thought to improve its readability, similar as it was initially but keeping the ampersands. Hope it helps.

Cheers

Break down the script into multiple lines, but remaining the
ampersands so it fails if any part of the command fails
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.051% when pulling ec20230 on igncp:master into 0e01d9a on ReactiveX:master.

@kwonoj
Copy link
Member

kwonoj commented Oct 11, 2016

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.041% when pulling e7dd90c on igncp:master into ece1b89 on ReactiveX:master.

@coveralls
Copy link

coveralls commented Oct 24, 2016

Coverage Status

Coverage remained the same at 97.041% when pulling e7dd90c on igncp:master into ece1b89 on ReactiveX:master.

@jayphelps jayphelps merged commit f93cb1d into ReactiveX:master Oct 24, 2016
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants