fix(operators): export reserved name operators on prototype#1927
Merged
jayphelps merged 1 commit intoReactiveX:masterfrom Sep 9, 2016
Merged
fix(operators): export reserved name operators on prototype#1927jayphelps merged 1 commit intoReactiveX:masterfrom
jayphelps merged 1 commit intoReactiveX:masterfrom
Conversation
Contributor
Author
|
cc @IgorMinar |
Member
|
Had an extraneous semicolon that was failing the build, so I removed it. Used it as an opportunity to try out the new ability for maintainers to modify submitted PR branches directly (even Although I don't like this solution, I can't think of any other one. This whole underscore business is unfortunate to begin with. So that said, I think this is acceptable. I'll wait a few days to see if anyone wants to object? |
Member
|
LGTM |
Member
|
Needs rebase tho |
Contributor
|
rebased as #1932 |
Member
|
@IgorMinar I rebased this already, is that the only change? |
Contributor
|
@jayphelps I just rebased. no other changes. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1924