style(scan): updated signatures for scan and reduce#1847
style(scan): updated signatures for scan and reduce#1847kwonoj merged 1 commit intoReactiveX:masterfrom
Conversation
|
Is there any danger in combining the two signature interfaces since they are identical? |
: Yes, interesting point. Signature seems could be reused, most pain point maybe having good name for common type? |
|
The common name I would go with is reduce, simply because they are both reduce operations. |
|
for me those name looks fine. |
|
Nice work @david-driscoll |
6d54973 to
1bd06a6
Compare
|
Branch updated. |
|
LGTM |
|
@david-driscoll , would you able to check PR? it still says diverged from master, not able to merge. |
|
Whoops, one sec. |
This change makes working with scan and reduce a little easier without having to cast the types.
1bd06a6 to
b447525
Compare
|
Rebased. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
This change makes working with scan/reduce a little easier in TypeScript based applications.
Related issue (if exists):
None that I'm aware of.
This change makes working with scan and reduce a little easier without having to cast the types.