Skip to content

style(scan): updated signatures for scan and reduce#1847

Merged
kwonoj merged 1 commit intoReactiveX:masterfrom
david-driscoll:scan-signature
Jul 29, 2016
Merged

style(scan): updated signatures for scan and reduce#1847
kwonoj merged 1 commit intoReactiveX:masterfrom
david-driscoll:scan-signature

Conversation

@david-driscoll
Copy link
Member

Description:
This change makes working with scan/reduce a little easier in TypeScript based applications.

Related issue (if exists):
None that I'm aware of.

This change makes working with scan and reduce a little easier without having to cast the types.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.707% when pulling 6d54973 on david-driscoll:scan-signature into 1590304 on ReactiveX:master.

@paulpdaniels
Copy link
Contributor

Is there any danger in combining the two signature interfaces since they are identical?

@kwonoj
Copy link
Member

kwonoj commented Jul 26, 2016

Is there any danger in combining the two signature interfaces since they are identical?

: Yes, interesting point. Signature seems could be reused, most pain point maybe having good name for common type?

@david-driscoll
Copy link
Member Author

The common name I would go with is reduce, simply because they are both reduce operations. reduce just happens on complete, and scan happens on next.

@kwonoj
Copy link
Member

kwonoj commented Jul 28, 2016

for me those name looks fine.

@benlesh
Copy link
Member

benlesh commented Jul 28, 2016

Nice work @david-driscoll

@david-driscoll
Copy link
Member Author

Branch updated.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.722% when pulling 1bd06a6 on david-driscoll:scan-signature into e366734 on ReactiveX:master.

@kwonoj
Copy link
Member

kwonoj commented Jul 29, 2016

LGTM

@kwonoj
Copy link
Member

kwonoj commented Jul 29, 2016

@david-driscoll , would you able to check PR? it still says diverged from master, not able to merge.

@david-driscoll
Copy link
Member Author

Whoops, one sec.

This change makes working with scan and reduce a little easier without having to cast the types.
@david-driscoll
Copy link
Member Author

Rebased.

@coveralls
Copy link

coveralls commented Jul 29, 2016

Coverage Status

Coverage remained the same at 96.722% when pulling b447525 on david-driscoll:scan-signature into e366734 on ReactiveX:master.

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants