Make inner class static for CompletableOnErrorComplete

[chintando]

Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:

After taking a heap dump for a Rx chain that was completed, we saw evidence of inner class showing up on the heap dump analysis. It apears that CompletableOnErrorComplete#onError is leaking the predicate

For instance

class Foo {

fun test(): Completable {
Completable.fromCallable {
println("hello world")
}.onErrorComplete { --> leaks after chain completion
true
}

}

}

Verified with kotlin bytecode dump and heap analysis

• Please give a description about what and why you are contributing, even if it's trivial.

• Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.

• Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an empty, just, range of values as well as an error source, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.

[akarnokd]

Your change makes no sense as the OnError loses the reference altogether and causes a compile error.

Usually a leak is caused by your application holding references, for example, in a CompositeDisposable which is not cleaned up. There are workarounds such as onTerminateDetach or using the 4 argument subscribe method that removes itself from a CompositeDisposable upon termination.

[chintando]

i believe the OnError should have been taking the predicate as part of constructor, won't the onError hold on to predicate thereby not being able to clean up the predicate object? Just curious

[akarnokd]

Predicates are never cleared in RxJava.

i believe the OnError should have been taking the predicate as part of constructor

Yes, that could be done. If you want, you can resubmit the PR with this change.

[chintando]

sure thing will do