Skip to content

Conversation

@RayWangQvQ
Copy link
Owner

内容

Update database file location and add entrypoint script for container

@RayWangQvQ RayWangQvQ requested a review from Copilot July 13, 2025 08:42

This comment was marked as outdated.

@RayWangQvQ RayWangQvQ requested a review from Copilot July 13, 2025 08:46

This comment was marked as outdated.

@RayWangQvQ RayWangQvQ requested a review from Copilot July 13, 2025 08:58

This comment was marked as outdated.

@RayWangQvQ RayWangQvQ requested a review from Copilot July 13, 2025 09:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SQLite database file location to a dedicated config directory and adds a container entrypoint script to handle migration and startup. It also bumps the project version and adjusts the Docker setup.

  • Move default DB path to ./config/BiliBiliTool.db in appsettings.json
  • Introduce docker/entrypoint.sh for DB migration and launching the .NET app
  • Update Dockerfile to copy and execute the new script; bump version to 3.3.3 and note changes in CHANGELOG.md

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Ray.BiliBiliTool.Web/appsettings.json Updated SQLite connection string to use the config directory
docker/entrypoint.sh Added entrypoint script to migrate existing DB and start service
common.props Bumped version from 3.3.2 to 3.3.3
Dockerfile Copied entrypoint script, removed old ENTRYPOINT, set permissions
CHANGELOG.md Added new section for version 3.3.3
Comments suppressed due to low confidence (3)

docker/entrypoint.sh:10

  • [nitpick] The comment and log reference '3.3.0' are outdated given the version bump to 3.3.3. Consider updating or removing the hardcoded version number to avoid confusion.
# 3.3.0 need migrate db file location to /app/config

CHANGELOG.md:2

  • The changelog entry for version 3.3.3 only mentions the database location change but omits the addition of the container entrypoint script. Consider adding a bullet to document the new entrypoint script feature.
- Feature: 变更默认数据库文件位置到 /app/config 下

docker/entrypoint.sh:11

  • The migration logic for moving the database file is new behavior that isn't covered by automated tests. Consider adding integration or unit tests to verify the migration executes correctly when upgrading from older versions.
if [ -f "/app/BiliBiliTool.db" ]; then

@RayWangQvQ RayWangQvQ merged commit c96a304 into develop Jul 13, 2025
@RayWangQvQ RayWangQvQ deleted the feature/db-file branch July 13, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant