-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Separate daily tasks #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate daily tasks #944
Conversation
…lege, Silver2Coin, and Charge tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR separates the previous monolithic daily task into individual scheduled Quartz jobs with their own configuration entries, service implementations, and shell scripts, and bumps the version to 3.3.1.
- Introduce discrete
Manga,MangaPrivilege,Silver2Coin,Charge, andVipPrivilegeQuartz jobs and remove them fromDailyTaskAppService. - Add specific
"*TaskConfig"entries in both Web and Consoleappsettings.jsonand register each job/trigger inServiceCollectionQuartzConfiguratorExtensions. - Create dedicated
*TaskAppServiceclasses and updateTaskTypeFactoryand Contracts accordingly; bump version incommon.propsand updateCHANGELOG.md.
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Ray.BiliBiliTool.Web/appsettings.json | Added separate task config blocks and repositioned VipBigPointConfig. |
| src/Ray.BiliBiliTool.Web/Jobs/*.cs | Added individual Quartz job classes for each task. |
| src/Ray.BiliBiliTool.Web/Extensions/ServiceCollectionQuartzConfiguratorExtensions.cs | Registered new jobs/triggers for each task. |
| src/Ray.BiliBiliTool.Application/*TaskAppService.cs | Created distinct application services for each task and refactored out from daily. |
| src/Ray.BiliBiliTool.Application/DailyTaskAppService.cs | Removed discrete tasks now handled by separate jobs. |
| src/Ray.BiliBiliTool.Application.Contracts/TaskTypeFactory.cs | Added new task interfaces to the factory. |
| common.props | Bumped version to 3.3.1. |
| CHANGELOG.md | Added changelog entry for 3.3.1. |
Comments suppressed due to low confidence (2)
src/Ray.BiliBiliTool.Web/appsettings.json:62
- [nitpick] Consider renaming this block to "VipPrivilegeTaskConfig" for consistency with other task config keys like "Silver2CoinTaskConfig".
"VipPrivilegeConfig": {
src/Ray.BiliBiliTool.Web/Extensions/ServiceCollectionQuartzConfiguratorExtensions.cs:47
- [nitpick] Update this comment to "// VipPrivilege job" to match the class name and naming convention.
// ReceiveVipPrivilege job
src/Ray.BiliBiliTool.Web/Extensions/ServiceCollectionQuartzConfiguratorExtensions.cs
Outdated
Show resolved
Hide resolved
src/Ray.BiliBiliTool.Web/Extensions/ServiceCollectionQuartzConfiguratorExtensions.cs
Show resolved
Hide resolved
…figuratorExtensions.cs Co-authored-by: Copilot <[email protected]>
内容
Separate daily tasks