Skip to content

Conversation

@RayWangQvQ
Copy link
Owner

内容

Separate daily tasks

@RayWangQvQ RayWangQvQ requested a review from Copilot June 20, 2025 19:32

This comment was marked as outdated.

@RayWangQvQ RayWangQvQ requested a review from Copilot June 21, 2025 05:25

This comment was marked as outdated.

@RayWangQvQ RayWangQvQ requested a review from Copilot June 21, 2025 05:50

This comment was marked as outdated.

@RayWangQvQ RayWangQvQ requested a review from Copilot July 10, 2025 19:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates the previous monolithic daily task into individual scheduled Quartz jobs with their own configuration entries, service implementations, and shell scripts, and bumps the version to 3.3.1.

  • Introduce discrete Manga, MangaPrivilege, Silver2Coin, Charge, and VipPrivilege Quartz jobs and remove them from DailyTaskAppService.
  • Add specific "*TaskConfig" entries in both Web and Console appsettings.json and register each job/trigger in ServiceCollectionQuartzConfiguratorExtensions.
  • Create dedicated *TaskAppService classes and update TaskTypeFactory and Contracts accordingly; bump version in common.props and update CHANGELOG.md.

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Ray.BiliBiliTool.Web/appsettings.json Added separate task config blocks and repositioned VipBigPointConfig.
src/Ray.BiliBiliTool.Web/Jobs/*.cs Added individual Quartz job classes for each task.
src/Ray.BiliBiliTool.Web/Extensions/ServiceCollectionQuartzConfiguratorExtensions.cs Registered new jobs/triggers for each task.
src/Ray.BiliBiliTool.Application/*TaskAppService.cs Created distinct application services for each task and refactored out from daily.
src/Ray.BiliBiliTool.Application/DailyTaskAppService.cs Removed discrete tasks now handled by separate jobs.
src/Ray.BiliBiliTool.Application.Contracts/TaskTypeFactory.cs Added new task interfaces to the factory.
common.props Bumped version to 3.3.1.
CHANGELOG.md Added changelog entry for 3.3.1.
Comments suppressed due to low confidence (2)

src/Ray.BiliBiliTool.Web/appsettings.json:62

  • [nitpick] Consider renaming this block to "VipPrivilegeTaskConfig" for consistency with other task config keys like "Silver2CoinTaskConfig".
  "VipPrivilegeConfig": {

src/Ray.BiliBiliTool.Web/Extensions/ServiceCollectionQuartzConfiguratorExtensions.cs:47

  • [nitpick] Update this comment to "// VipPrivilege job" to match the class name and naming convention.
        // ReceiveVipPrivilege job

@RayWangQvQ RayWangQvQ merged commit 40b484d into develop Jul 10, 2025
2 checks passed
@RayWangQvQ RayWangQvQ deleted the feature/seperate branch July 10, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant