fix: Avoid locking up the test suite#9821
Merged
Merged
Conversation
mikeharv
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
This PR fixes an issue that could cause the entire test suite page/tab to entirely freeze when a failed assertion was encountered. For undetermined reasons, trying to calculate/display the diff of certain objects would have this effect. Now, diffs are suppressed, so the assert will simply fail normally and allow the rest of the test suite to continue merrily on its way. Tests generally shouldn't be failing, and if they are the first thing to do is to investigate the cause, so not having diffs automatically displayed is not a large burden vs manually binary searching for failing tests when a code change causes multiple breakages that can't be identified because the whole test suite locks up.