Skip to content

refactor: remove redundant flyout positioning. #8573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 2 commits into from
Sep 18, 2024
Merged

refactor: remove redundant flyout positioning. #8573

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e5802d
refactor: remove redundant flyout positioning.
gonfunko Sep 11, 2024
e19cf8b
fix: handle the case where there is a flyout without a toolbox
gonfunko Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions core/workspace_svg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,9 +1050,6 @@ export class WorkspaceSvg extends Workspace implements IASTNodeLocationSvg {
if (this.toolbox_) {
this.toolbox_.position();
}
if (this.flyout) {
Comment thread
gonfunko marked this conversation as resolved.
this.flyout.position();
}

const positionables = this.componentManager.getComponents(
ComponentManager.Capability.POSITIONABLE,
Expand Down