fix(comments): added workspace comments and comment drag strategy isDeadOrDying() checks (for multiselect plugin)#8532
Merged
Conversation
…ded blocklyDraggable class to ws comments
1 task
HollowMan6
reviewed
Aug 16, 2024
HollowMan6
reviewed
Aug 16, 2024
Contributor
HollowMan6
left a comment
HollowMan6
left a comment
There was a problem hiding this comment.
There are some formatting issue here as well (CI fails)
cpcallen
approved these changes
Aug 21, 2024
Collaborator
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
Change seems pretty reasonable even absent any context other than that it makes comments consistent with blocks, so I'll go ahead and approve this.
There is one other thing, though: screenshots are not very searchable. Can you supplement them with markdown-formatted text and/or (since they seem to be screenshotted from another GitHub conversation) a link to wherever page they originally came from (if public)?
cpcallen
changed the title
cpcallen
changed the title
Collaborator
|
I'm going to go ahead and merge this, but @changminbark please update the description to make it easer to search. |
changminbark
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8531
Proposed Changes
Added the isDeadOrDying() checks for the workspace comment's isDeletable and comment drag strategy's isMovable methods (such as the ones that are already implemented for blocks.
Reason for Changes
Fixes a bug in the multiselect plugin:
After multiselecting comments, copy/pasting them, and then undoing that action does not get rid of the comments from the multiselection. This is usually not a problem as it also happens to blocks. However, the blocks and comments have different isMovable (drag strategy) and isDeletable methods, which lead to a breaking behavior in the multiselect plugin. I have already tested a fix for this by implementing the missing isDeadOrDying() check for the isMovable and isDeletable methods for comments.
Test Coverage
Documentation
Additional Information