fix: update disabled status after rendering#7172
Merged
Merged
Conversation
BeksOmega
approved these changes
Jun 15, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7113
Proposed Changes
Calls
updateDisabledif the block is disabled during therendercall for a block.The reason this happened in JSON and not XML is that XML sets the disabled state after rendering. JSON sets it before rendering. When the block was eventually rendered in JSON, it looked correct because it had the correct
enabledproperty, but thevisuallyDisabledproperty was not set (because the block was not rendered at the time of the originalupdateDisabledcall). So this just calls that function again during render which updates the state as needed.Behavior Before Change
See detailed reproduction steps in linked bug. If you loaded from json, the block would look and be disabled, but the block's
visuallyDisabledproperty was not set. So the visual state would be out of sync with the actual state of the block.Behavior After Change
Disabled blocks loaded from json behave as expected.
Reason for Changes
bug fixes
Test Coverage
manual testing, added test case
Documentation
no
Additional Information